Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: .github/workflows/api.yml test upload to staging step using api-staging.web3.storage now has continue-on-error: true #2356

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Jan 22, 2024

...to be resilient to staging writes being disabled

Motivation:

…taging.web3.storage now has continue-on-error: true to be resilient to staging writes being disabled
@gobengo gobengo marked this pull request as ready for review January 22, 2024 19:53
@gobengo gobengo requested a review from a team as a code owner January 22, 2024 19:53
@gobengo gobengo requested review from olizilla and alanshaw January 22, 2024 19:53
@gobengo gobengo self-assigned this Jan 22, 2024
@gobengo gobengo merged commit 1a7233d into main Jan 25, 2024
6 checks passed
@gobengo gobengo deleted the api-release-staging-allow-write-error branch January 25, 2024 00:34
gobengo added a commit that referenced this pull request Mar 11, 2024
…taging.web3.storage now has continue-on-error: true (#2356)

...to be resilient to staging writes being disabled

Motivation:
* this pipeline after merging a release-please PR failed the deploy to
staging job and I think this change would make it green.
https://github.com/web3-storage/web3.storage/actions/runs/7616473142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants